projects / haproxy-2.5.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: b406b87) | patch
BUG/MEDIUM: cli/ssl: don't store base64dec() result in the trash's length
authorWilly Tarreau <w@1wt.eu>
Wed, 22 Aug 2018 03:26:57 +0000 (05:26 +0200)
committerWilly Tarreau <w@1wt.eu>
Wed, 22 Aug 2018 03:28:32 +0000 (05:28 +0200)
commit1c913e4232c82777bb1bcb2266f34670d5174342
tree6918a9d5d8f20a08259431b5e4d072bb847aa204tree | snapshot
parentb406b8708fef5ff51e684794b5df4fea728b0058commit | diff
BUG/MEDIUM: cli/ssl: don't store base64dec() result in the trash's length

By convenience or laziness we used to store base64dec()'s return code
into trash.data and to compare it against 0 to check for conversion
failure, but it's now unsigned since commit 843b7cb ("MEDIUM: chunks:
make the chunk struct's fields match the buffer struct"). Let's clean
this up and test the result itself without storing it first.

No backport is needed.
src/ssl_sock.c diff | blob | history
haproxy-2.5 public tree. Stable production code.