projects / haproxy-2.5.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 446344c) | patch
BUG/MINOR threads: Use get_(local|gm)time instead of (local|gm)time
authorTim Duesterhus <tim@bastelstu.be>
Sat, 28 Aug 2021 21:57:01 +0000 (23:57 +0200)
committerWilly Tarreau <w@1wt.eu>
Mon, 30 Aug 2021 04:14:32 +0000 (06:14 +0200)
commit1f269c12dc31bb63db31559cb44c187ab91abb64
tree300eee5b70b0a78f9b8fa708aa32feb4e38ede6ftree | snapshot
parent446344ccef8d5e1358394da7bd0de8625cb2bcb8commit | diff
BUG/MINOR threads: Use get_(local|gm)time instead of (local|gm)time

Using localtime / gmtime is not thread-safe, whereas the `get_*` wrappers are.

Found using GitHub's CodeQL scan.

The use in sample_conv_ltime() can be traced back to at least
fac9ccfb705702f211f99e67d5f5d5129002086a (first appearing in 1.6-dev3), so all
supported branches with thread support are affected.
src/http_conv.c diff | blob | history
src/sample.c diff | blob | history
haproxy-2.5 public tree. Stable production code.