projects / haproxy-3.0.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: d721571) | patch
BUG/MINOR: quic: Wrong rtt variance computing
authorFrédéric Lécaille <flecaille@haproxy.com>
Thu, 30 Mar 2023 13:31:06 +0000 (15:31 +0200)
committerFrédéric Lécaille <flecaille@haproxy.com>
Fri, 31 Mar 2023 11:41:17 +0000 (13:41 +0200)
commit5d5afe790016401952117dbaff8a3324260faf8e
tree7000f5de933a336d7e017d7c61cabe46932541dbtree | snapshot
parentd721571d265cc07d0365448f97ccb6ab8423434fcommit | diff
BUG/MINOR: quic: Wrong rtt variance computing

In ->srtt quic_loss struct this is 8*srtt which is stored so that not to have to multiply/devide
it to compute the RTT variance (at least). This is where there was a bug in quic_loss_srtt_update():
each time ->srtt must be used, it must be devided by 8 or right shifted by 3.
This bug had a very bad impact for network with non negligeable packet loss.

Must be backported to 2.6 and 2.7.
src/quic_loss.c diff | blob | history
haproxy-3.0 public tree. Stable production code.