BUG/MAJOR: http/htx: prevent unbounded loop in http_manage_server_side_cookies
authorAndrew McDermott <aim@frobware.com>
Fri, 11 Feb 2022 18:26:49 +0000 (18:26 +0000)
committerWilly Tarreau <w@1wt.eu>
Wed, 16 Feb 2022 13:44:47 +0000 (14:44 +0100)
commitd8ce72f63e115fa0952e6a58e81c3d15dfc0a509
treedc39e59203c5e5aea2e3d5e6e5283ad015767421
parent6a23b1249e372d79f7d967f6533ddd31268fe1b6
BUG/MAJOR: http/htx: prevent unbounded loop in http_manage_server_side_cookies

Ensure calls to http_find_header() terminate. If a "Set-Cookie2"
header is found then the while(1) loop in
http_manage_server_side_cookies() will never terminate, resulting in
the watchdog firing and the process terminating via SIGABRT.

The while(1) loop becomes unbounded because an unmatched call to
http_find_header("Set-Cookie") will leave ctx->blk=NULL. Subsequent
calls to check for "Set-Cookie2" will now enumerate from the beginning
of all the blocks and will once again match on subsequent
passes (assuming a match first time around), hence the loop becoming
unbounded.

This issue was introduced with HTX and this fix should be backported
to all versions supporting HTX.

Many thanks to Grant Spence (gspence@redhat.com) for working through
this issue with me.

(cherry picked from commit bfb15ab34ead85f64cd6da0e9fb418c9cd14cee8)
Signed-off-by: Willy Tarreau <w@1wt.eu>
src/http_ana.c