BUG/MINOR: fcgi-app: handle a possible strdup() failure
authorIlia Shipitsin <chipitsine@gmail.com>
Mon, 5 Aug 2024 18:59:09 +0000 (20:59 +0200)
committerChristopher Faulet <cfaulet@haproxy.com>
Tue, 3 Sep 2024 16:37:59 +0000 (18:37 +0200)
This defect was found by the coccinelle script "unchecked-strdup.cocci".
It can be backported to 2.2.

(cherry picked from commit aaaacaaf4b558f4e0206b98c787cdcef773b1d76)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>

src/fcgi-app.c

index e8117a3..7321197 100644 (file)
@@ -606,6 +606,8 @@ static int proxy_parse_use_fcgi_app(char **args, int section, struct proxy *curp
        if (!fcgi_conf)
                goto err;
        fcgi_conf->name = strdup(args[1]);
+       if (!fcgi_conf->name)
+               goto err;
        LIST_INIT(&fcgi_conf->param_rules);
        LIST_INIT(&fcgi_conf->hdr_rules);