CLEANUP: connection: Stop directly setting an ist's .ptr

Instead replace the complete `ist` by the value returned from `ist2`.

This was noticed during review of issue #549.

diff --git a/src/connection.c b/src/connection.c
index c1ec266..462dbf0 100644 (file)
--- a/src/connection.c
+++ b/src/connection.c
@@ -760,7 +760,7 @@ int conn_recv_proxy(struct connection *conn, int flag)
 
                                if (tlv.len > UNIQUEID_LEN)
                                        goto bad_header;
-                               conn->proxy_unique_id.ptr = pool_alloc(pool_head_uniqueid);
+                               conn->proxy_unique_id = ist2(pool_alloc(pool_head_uniqueid), 0);
                                if (!isttest(conn->proxy_unique_id))
                                        goto fail;
                                if (istcpy(&conn->proxy_unique_id, tlv, UNIQUEID_LEN) < 0) {