projects
/
haproxy-2.5.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
90e9b8c
)
CLEANUP: sockpair: silence a coverity check about fcntl()
author
Willy Tarreau
<w@1wt.eu>
Fri, 5 Mar 2021 13:31:52 +0000
(14:31 +0100)
committer
Willy Tarreau
<w@1wt.eu>
Fri, 5 Mar 2021 13:33:13 +0000
(14:33 +0100)
This is about coverity complaining that we didn't check the fcntl call
which can't fail, let's consume it. This is issue #1158.
src/proto_sockpair.c
patch
|
blob
|
history
diff --git
a/src/proto_sockpair.c
b/src/proto_sockpair.c
index
ca4fc6d
..
306213e
100644
(file)
--- a/
src/proto_sockpair.c
+++ b/
src/proto_sockpair.c
@@
-479,7
+479,7
@@
struct connection *sockpair_accept_conn(struct listener *l, int *status)
int cfd;
if ((cfd = recv_fd_uxst(l->rx.fd)) != -1)
- fcntl(cfd, F_SETFL, O_NONBLOCK);
+ DISGUISE(fcntl(cfd, F_SETFL, O_NONBLOCK));
if (likely(cfd != -1)) {
/* Perfect, the connection was accepted */