BUG/MEDIUM: peers: reset commitupdate value in new conns

The commitupdate value of the table is used to check if the update
is still pending for a push for all peers. To be sure to not miss a
push we reset it just after a handshake success.

This patch should be backported on all supported branches ( >= 1.6 )

(cherry picked from commit cc9cce9351c2d64476dbe2f35c43cde8a3f97ebe)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>

diff --git a/src/peers.c b/src/peers.c
index 3e1f201..048918b 100644 (file)
--- a/src/peers.c
+++ b/src/peers.c
@@ -2403,6 +2403,8 @@ static inline void init_accepted_peer(struct peer *peer, struct peers *peers)
                if ((int)(st->table->localupdate - st->update) < 0)
                        st->update = st->table->localupdate + (2147483648U);
                st->teaching_origin = st->last_pushed = st->update;
+               if ((int)(st->last_pushed - st->table->commitupdate) > 0)
+                       st->table->commitupdate = st->last_pushed;
                HA_SPIN_UNLOCK(STK_TABLE_LOCK, &st->table->lock);
        }
 
@@ -2453,6 +2455,8 @@ static inline void init_connected_peer(struct peer *peer, struct peers *peers)
                if ((int)(st->table->localupdate - st->update) < 0)
                        st->update = st->table->localupdate + (2147483648U);
                st->teaching_origin = st->last_pushed = st->update;
+               if ((int)(st->last_pushed - st->table->commitupdate) > 0)
+                       st->table->commitupdate = st->last_pushed;
                HA_SPIN_UNLOCK(STK_TABLE_LOCK, &st->table->lock);
        }