BUG/MINOR: ssl: double free w/ smp_fetch_ssl_x_chain_der()

smp_fetch_ssl_x_chain_der() uses the SSL_get_peer_cert_chain() which
does not increment the refcount of the chain, so it should not be free'd.

The bug was introduced by a598b50 ("MINOR: ssl: add ssl_{c,s}_chain_der
fetch methods"). No backport needed.

diff --git a/src/ssl_sample.c b/src/ssl_sample.c
index a21ae33..0f59365 100644 (file)
--- a/src/ssl_sample.c
+++ b/src/ssl_sample.c
@@ -198,8 +198,6 @@ smp_fetch_ssl_x_chain_der(const struct arg *args, struct sample *smp, const char
 out:
        if (tmp_trash)
                free_trash_chunk(tmp_trash);
-       if (certs)
-               sk_X509_pop_free(certs, X509_free);
        return ret;
 }