CI: github actions: clean default step conditions
authorIlya Shipitsin <chipitsine@gmail.com>
Fri, 7 Jan 2022 15:09:35 +0000 (20:09 +0500)
committerChristopher Faulet <cfaulet@haproxy.com>
Tue, 11 Jan 2022 16:56:03 +0000 (17:56 +0100)
step condition "if: ${{ !failure() }}" was added in 2ef4c7c84363f5a9b80a2093df1370514319db28
during my experiments. As Tim Düsterhus mentioned, that condition is default and may be omitted.

(cherry picked from commit 65eab587a2ce58f2c8b92d03568a33ee7dc45528)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>

.github/workflows/vtest.yml

index 3c3fbf6..b67090a 100644 (file)
@@ -84,7 +84,6 @@ jobs:
           ADDLIB="-Wl,-rpath,/usr/local/lib/ -Wl,-rpath,$HOME/opt/lib/"
         sudo make install
     - name: Show HAProxy version
-      if: ${{ !failure() }}
       id: show-version
       run: |
         echo "::group::Show dynamic libraries."
@@ -99,11 +98,9 @@ jobs:
         haproxy -vv
         echo "::set-output name=version::$(haproxy -v |awk 'NR==1{print $3}')"
     - name: Install problem matcher for VTest
-      if: ${{ !failure() }}
       # This allows one to more easily see which tests fail.
       run: echo "::add-matcher::.github/vtest.json"
     - name: Run VTest for HAProxy ${{ steps.show-version.outputs.version }}
-      if: ${{ !failure() }}
       id: vtest
       run: |
         # This is required for macOS which does not actually allow to increase