From: Willy Tarreau <w@1wt.eu>
Date: Fri, 26 Feb 2021 20:12:15 +0000 (+0100)
Subject: CLEANUP: ssl: remove a useless "if" before freeing an error message
X-Git-Tag: v2.4-dev10~3
X-Git-Url: http://git.haproxy.org/?a=commitdiff_plain;h=01acf563a77276b6b671271244d2823867ad8db7;p=haproxy-2.5.git

CLEANUP: ssl: remove a useless "if" before freeing an error message

Just an old "if (err) free(err)" that managed to escape cleanups.
---

diff --git a/src/ssl_sock.c b/src/ssl_sock.c
index a59b34d..580c6fe 100644
--- a/src/ssl_sock.c
+++ b/src/ssl_sock.c
@@ -5117,7 +5117,7 @@ ssl_sock_load_ca(struct bind_conf *bind_conf)
 	if (ssl_sock_load_files_into_ckch(bind_conf->ca_sign_file, ckch, &err)) {
 		ha_alert("Proxy '%s': Failed to read CA certificate file '%s' at [%s:%d]. Chain loading failed: %s\n",
 			px->id, bind_conf->ca_sign_file, bind_conf->file, bind_conf->line, err);
-		if (err) free(err);
+		free(err);
 		goto failed;
 	}