From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Wed, 7 Jul 2021 15:17:39 +0000 (+0200)
Subject: BUILD: http_htx: fix ci compilation error with isdigit for Windows
X-Git-Tag: v2.5-dev2~32
X-Git-Url: http://git.haproxy.org/?a=commitdiff_plain;h=164ae4ad55bdd36d22cba8568227895ef5ddc086;p=haproxy-2.5.git

BUILD: http_htx: fix ci compilation error with isdigit for Windows

The warning is encountered on platforms for which char type is signed by
default.

cf the following links
https://stackoverflow.com/questions/10186219/array-subscript-has-type-char

This must be backported up to 2.4.
---

diff --git a/src/http_htx.c b/src/http_htx.c
index 6c288f9..399848d 100644
--- a/src/http_htx.c
+++ b/src/http_htx.c
@@ -1760,7 +1760,7 @@ int http_scheme_based_normalize(struct htx *htx)
 	authority = http_get_authority(uri, 0);
 	start = istptr(authority);
 	end = istend(authority);
-	for (ptr = end; ptr > start && isdigit(*--ptr); )
+	for (ptr = end; ptr > start && isdigit((unsigned char)*--ptr); )
 		;
 
 	/* if no port found, no normalization to proceed */