From: Willy Tarreau <w@1wt.eu>
Date: Thu, 24 Feb 2022 15:37:19 +0000 (+0100)
Subject: BUG/MINOR: proxy: preset the error message pointer to NULL in parse_new_proxy()
X-Git-Tag: v2.5.4~4
X-Git-Url: http://git.haproxy.org/?a=commitdiff_plain;h=1c54f46;p=haproxy-2.5.git

BUG/MINOR: proxy: preset the error message pointer to NULL in parse_new_proxy()

As reported by Coverity in issue #1568, a missing initialization of the
error message pointer in parse_new_proxy() may result in displaying garbage
or crashing in case of memory allocation error when trying to create a new
proxy on startup.

This should be backported to 2.4.

(cherry picked from commit 282b6a7539add7517f2b16cc82b6a3509492fd76)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
---

diff --git a/src/proxy.c b/src/proxy.c
index e583e51..c671831 100644
--- a/src/proxy.c
+++ b/src/proxy.c
@@ -1838,7 +1838,7 @@ struct proxy *parse_new_proxy(const char *name, unsigned int cap,
                               const struct proxy *defproxy)
 {
 	struct proxy *curproxy = NULL;
-	char *errmsg;
+	char *errmsg = NULL;
 
 	if (!(curproxy = alloc_new_proxy(name, cap, &errmsg))) {
 		ha_alert("parsing [%s:%d] : %s\n", file, linenum, errmsg);