From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Fri, 10 Feb 2023 15:35:43 +0000 (+0100)
Subject: BUG/MINOR: quic: Missing call to task_queue() in qc_idle_timer_do_rearm()
X-Git-Tag: v2.8-dev5~176
X-Git-Url: http://git.haproxy.org/?a=commitdiff_plain;h=1e8ef1bed6ef687e66578214f0b184aab37b4154;p=haproxy-3.0.git

BUG/MINOR: quic: Missing call to task_queue() in qc_idle_timer_do_rearm()

The aim of this function is to rearm the idle timer. The ->expire
field of the timer task was updated without being requeued.
Some connection could be unexpectedly terminated.

Must be backported to 2.6 and 2.7.
---

diff --git a/src/quic_conn.c b/src/quic_conn.c
index a44c28d..cbead12 100644
--- a/src/quic_conn.c
+++ b/src/quic_conn.c
@@ -5221,6 +5221,7 @@ static void qc_idle_timer_do_rearm(struct quic_conn *qc)
 
 	expire = QUIC_MAX(3 * quic_pto(qc), qc->max_idle_timeout);
 	qc->idle_timer_task->expire = tick_add(now_ms, MS_TO_TICKS(expire));
+	task_queue(qc->idle_timer_task);
 }
 
 /* Rearm the idle timer for <qc> QUIC connection depending on <read> boolean