From: Ilya Shipitsin Date: Wed, 10 Feb 2021 08:03:30 +0000 (+0500) Subject: CLEANUP: remove unused variable assigned found by Coverity X-Git-Tag: v2.4-dev8~80 X-Git-Url: http://git.haproxy.org/?a=commitdiff_plain;h=a1e0f387c77212564a3b727d313eee79d273a786;p=haproxy-2.5.git CLEANUP: remove unused variable assigned found by Coverity this is pure cleanup, no need to backport 2116 if ((end - 1) == (payload + strlen(PAYLOAD_PATTERN))) { 2117 /* if the payload pattern is at the end */ 2118 s->pcli_flags |= PCLI_F_PAYLOAD; CID 1399833 (#1 of 1): Unused value (UNUSED_VALUE)assigned_value: Assigning value from reql to ret here, but that stored value is overwritten before it can be used. 2119 ret = reql; 2120 } This patch fixes the issue #1048. --- diff --git a/src/cli.c b/src/cli.c index bfce9a6..8b32e76 100644 --- a/src/cli.c +++ b/src/cli.c @@ -2184,7 +2184,6 @@ int pcli_parse_request(struct stream *s, struct channel *req, char **errmsg, int if ((end - 1) == (payload + strlen(PAYLOAD_PATTERN))) { /* if the payload pattern is at the end */ s->pcli_flags |= PCLI_F_PAYLOAD; - ret = reql; } *(end-1) = '\n';