From: Christopher Faulet <cfaulet@haproxy.com>
Date: Fri, 14 Jan 2022 14:03:22 +0000 (+0100)
Subject: BUG/MINOR: sink: Use the right field in appctx context in release callback
X-Git-Tag: v2.5.3~14
X-Git-Url: http://git.haproxy.org/?a=commitdiff_plain;h=eed3cab77026bafde5277788580e9b42bdd81df5;p=haproxy-2.5.git

BUG/MINOR: sink: Use the right field in appctx context in release callback

In the release callback, ctx.peers was used instead of ctx.sft. Concretly,
it is not an issue because the appctx context is an union and these both
fields are structures with a unique pointer. But it will be a problem if
that changes.

This patch must be backported as far as 2.2.

(cherry picked from commit dd0b144c3ae83c2ea14f969cb58fa4b927c2c455)
Signed-off-by: William Lallemand <wlallemand@haproxy.org>
---

diff --git a/src/sink.c b/src/sink.c
index 9e4da9c..c1da18c 100644
--- a/src/sink.c
+++ b/src/sink.c
@@ -603,7 +603,7 @@ void __sink_forward_session_deinit(struct sink_forward_target *sft)
 
 static void sink_forward_session_release(struct appctx *appctx)
 {
-	struct sink_forward_target *sft = appctx->ctx.peers.ptr;
+	struct sink_forward_target *sft = appctx->ctx.sft.ptr;
 
 	if (!sft)
 		return;