From 06bf83e0ae101567796e05630ae227fb18d4e3e8 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Thu, 21 Jan 2021 09:13:35 +0100 Subject: [PATCH] MINOR: mux-h2/show_fd: report as suspicious an entry with too many calls An FD entry that maps to an H2C connection whose last stream was woken up more than 1M times is now flagged as suspicious. --- src/mux_h2.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mux_h2.c b/src/mux_h2.c index 2fbf196..fd03ea8 100644 --- a/src/mux_h2.c +++ b/src/mux_h2.c @@ -6202,9 +6202,10 @@ static int h2_show_fd(struct buffer *msg, struct connection *conn) int tree_cnt = 0; int orph_cnt = 0; struct buffer *hmbuf, *tmbuf; + int ret = 0; if (!h2c) - return 0; + return ret; list_for_each_entry(h2s, &h2c->fctl_list, list) fctl_cnt++; @@ -6257,12 +6258,14 @@ static int h2_show_fd(struct buffer *msg, struct connection *conn) chunk_appendf(&trash, " tl.calls=%d tl.ctx=%p tl.fct=", h2s->subs->tasklet->calls, h2s->subs->tasklet->context); + if (h2s->subs->tasklet->calls >= 1000000) + ret = 1; resolve_sym_name(&trash, NULL, h2s->subs->tasklet->process); chunk_appendf(&trash, ")"); } } } - return 0; + return ret; } /* Migrate the the connection to the current thread. -- 1.7.10.4