From 10518c0d59b52910404348c5148e623dec9f8873 Mon Sep 17 00:00:00 2001 From: Aurelien DARRAGON Date: Wed, 19 Apr 2023 10:33:02 +0200 Subject: [PATCH] CLEANUP: server: fix srv_set_{running, stopping, stopped} function comment Fixing function comments for the server state changing function since they still refer to asynchonous propagation of server state which is no longer in play. Moreover, there were some mixups between running/stopping. --- src/server.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/server.c b/src/server.c index ab73509..ff2832f 100644 --- a/src/server.c +++ b/src/server.c @@ -1581,10 +1581,9 @@ static void srv_append_more(struct buffer *msg, struct server *s, } } -/* Marks server down, regardless of its checks' statuses. The server is - * registered in a list to postpone the counting of the remaining servers on - * the proxy and transfers queued streams whenever possible to other servers at - * a sync point. Maintenance servers are ignored. +/* Marks server down, regardless of its checks' statuses. The server + * transfers queued streams whenever possible to other servers at a sync + * point. Maintenance servers are ignored. * * Must be called with the server lock held. */ @@ -1609,9 +1608,8 @@ void srv_set_stopped(struct server *s, enum srv_op_st_chg_cause cause) } /* Marks server up regardless of its checks' statuses and provided it isn't - * in maintenance. The server is registered in a list to postpone the counting - * of the remaining servers on the proxy and tries to grab requests from the - * proxy at a sync point. Maintenance servers are ignored. + * in maintenance. The server tries to grab requests from the proxy at a sync + * point. Maintenance servers are ignored. * * Must be called with the server lock held. */ @@ -1642,9 +1640,8 @@ void srv_set_running(struct server *s, enum srv_op_st_chg_cause cause) } /* Marks server stopping regardless of its checks' statuses and provided it - * isn't in maintenance. The server is registered in a list to postpone the - * counting of the remaining servers on the proxy and tries to grab requests - * from the proxy. Maintenance servers are ignored. + * isn't in maintenance. The server tries to redispatch pending requests + * to the proxy. Maintenance servers are ignored. * * Must be called with the server lock held. */ -- 1.7.10.4