From 19adeb56402a28701b8dd404db3bdf66d51eb050 Mon Sep 17 00:00:00 2001 From: Amaury Denoyelle Date: Wed, 25 Jan 2023 10:50:03 +0100 Subject: [PATCH] BUG/MINOR: h3: fix GOAWAY emission Since the rework of QUIC streams send scheduling, each stream has to be inserted in QUIC-mux send-list to be able to emit content. This was not the case for GOAWAY which prevent it to be sent. This regression has been introduced by the following patch : commit 20f2a425ffeda2e623aac4c702f4e44b1e122d1d MAJOR: mux-quic: rework stream sending priorization This new patch fixes the issue by inserting H3 control stream in mux send-list. The impact is deemed minor as for the moment GOAWAY is only sent just before connection/mux cleanup with a CONNECTION_CLOSE. However, it might cause some connections to hang up indefinitely. This should be backported up to 2.7. --- src/h3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/h3.c b/src/h3.c index 9a1d97d..7f0dc47 100644 --- a/src/h3.c +++ b/src/h3.c @@ -1682,6 +1682,7 @@ static int h3_send_goaway(struct h3c *h3c) } b_force_xfer(res, &pos, b_data(&pos)); + qcc_send_stream(qcs, 1); return 0; } -- 1.7.10.4