From 3b139e540aac5e2f2801d920be1c3c757ae33a8f Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Wed, 16 Sep 2020 16:24:14 +0200 Subject: [PATCH] BUG/MEDIUM: log-forward: always quit on parsing errors The err_code and goto were misplaced, causing a fatal parse error to be ignored when parsing a UDP listener's address. No backport is needed. --- src/log.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/log.c b/src/log.c index 984a31a..5f71bfe 100644 --- a/src/log.c +++ b/src/log.c @@ -3630,9 +3630,9 @@ int cfg_parse_log_forward(const char *file, int linenum, char **args, int kwm) else { ha_alert("parsing [%s:%d] : '%s %s' : error encountered while parsing listening address %s.\n", file, linenum, args[0], args[1], args[2]); - err_code |= ERR_ALERT | ERR_FATAL; - goto out; } + err_code |= ERR_ALERT | ERR_FATAL; + goto out; } list_for_each_entry(l, &bind_conf->listeners, by_bind) { /* Currently, only UDP handlers are allowed */ -- 1.7.10.4