From 437e48ad9244eaea63881b6c8a86a380c4eecc23 Mon Sep 17 00:00:00 2001 From: Emeric Brun Date: Wed, 28 Apr 2021 09:49:33 +0200 Subject: [PATCH] BUG/MEDIUM: peers: register last acked value as origin receiving a resync req Receiving a resync request, the origins to start the full sync and to reset after the full resync are mistakenly computed based on the last update on the table instead of computed based on the the last update acked by the node requesting the resync. It could result in disordered or missing updates pushing to the requester This patch sets correctly those origins. This patch should be backported on all supported branches ( >= 1.6 ) --- src/peers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/peers.c b/src/peers.c index 295b0ec..cff5696 100644 --- a/src/peers.c +++ b/src/peers.c @@ -2068,7 +2068,7 @@ static inline int peer_treat_awaited_msg(struct appctx *appctx, struct peer *pee NULL, &msg_head[1], peers->local->id, peer->id); /* prepare tables for a global push */ for (st = peer->tables; st; st = st->next) { - st->teaching_origin = st->last_pushed = st->table->update; + st->teaching_origin = st->last_pushed = st->update; st->flags = 0; } -- 1.7.10.4