From 5b988ebed1ebed47410de71bf87f919a4eba3319 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Tue, 3 May 2022 15:55:17 +0200 Subject: [PATCH] BUG/MINOR: quic: Dropped peer transport parameters The call to quic_dflt_transport_params_cpy() is already first done by quic_transport_params_init() which is a good thing. But this function was also called each time we parsed a transport parameters with quic_transport_param_decode(), re-initializing to default values some of them. The transport parameters concerned by this bug are the following: - max_udp_payload_size - ack_delay_exponent - max_ack_delay - active_connection_id_limit So, let's remove this call to quic_dflt_transport_params_cpy() which has nothing to do here! --- include/haproxy/xprt_quic.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/haproxy/xprt_quic.h b/include/haproxy/xprt_quic.h index a61af09..6ff29b4 100644 --- a/include/haproxy/xprt_quic.h +++ b/include/haproxy/xprt_quic.h @@ -607,7 +607,6 @@ static inline int quic_transport_param_decode(struct quic_transport_params *p, { const unsigned char *end = *buf + len; - quic_dflt_transport_params_cpy(p); switch (type) { case QUIC_TP_ORIGINAL_DESTINATION_CONNECTION_ID: if (!server || len >= sizeof p->original_destination_connection_id.data) -- 1.7.10.4