From 67b778418e6335b707c95a773f70318f96ff0664 Mon Sep 17 00:00:00 2001 From: William Lallemand Date: Wed, 10 Nov 2021 16:57:25 +0100 Subject: [PATCH] BUG/MEDIUM: httpclient/cli: free of unallocated hc->req.uri httpclient_new() sets the hc->req.uri ist without duplicating its memory, which is a problem since the string in the ist could be inaccessible at some point. The API was made to use a ist which was allocated dynamically, but httpclient_new() didn't do that, which result in a crash when calling istfree(). This patch fixes the problem by doing an istdup() Fix issue #1452. --- src/http_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/http_client.c b/src/http_client.c index fe85f05..4e5ef7c 100644 --- a/src/http_client.c +++ b/src/http_client.c @@ -535,7 +535,7 @@ struct httpclient *httpclient_new(void *caller, enum http_meth_t meth, struct is goto err; hc->caller = caller; - hc->req.url = url; + hc->req.url = istdup(url); hc->req.meth = meth; return hc; -- 1.7.10.4