From 6fd2576d5ebbe90039cc918d01d0f62970f7cd67 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Fri, 7 Apr 2023 19:01:33 +0200 Subject: [PATCH] MINOR: quic: Add a trace for packet with an ACK frame As the ACK frames are not added to the packet list of ack-eliciting frames, it could not be traced. But there is a flag to identify such packet. Let's use it to add this information to the traces of TX packets. Must be backported to 2.6 and 2.7. --- src/quic_conn.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/quic_conn.c b/src/quic_conn.c index 0cce20b..2d90ab3 100644 --- a/src/quic_conn.c +++ b/src/quic_conn.c @@ -658,6 +658,8 @@ static void quic_trace(enum trace_level level, uint64_t mask, const struct trace (unsigned long long)qc->path->in_flight); if (pkt) { const struct quic_frame *frm; + if (pkt->flags & QUIC_FL_TX_PACKET_ACK) + chunk_appendf(&trace_buf, " ack"); chunk_appendf(&trace_buf, " pn=%lu(%s) iflen=%llu", (unsigned long)pkt->pn_node.key, pkt->pktns == &qc->pktns[QUIC_TLS_PKTNS_INITIAL] ? "I" : -- 1.7.10.4