From 835712ad909fe1b36ee53f521d17bbc0a5df3794 Mon Sep 17 00:00:00 2001 From: William Dauchy Date: Sun, 18 Oct 2020 18:37:43 +0200 Subject: [PATCH] BUG/MINOR: listener: close before free in `listener_accept` safer to close handle before the object is put back in the global pool. this was introduced by commit 9378bbe0bef4005155d ("MEDIUM: listener: use protocol->accept_conn() to accept a connection") this should fix github issue #902 no backport needed. Signed-off-by: William Dauchy --- src/listener.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/listener.c b/src/listener.c index 85191f5..7061f9a 100644 --- a/src/listener.c +++ b/src/listener.c @@ -855,8 +855,8 @@ void listener_accept(struct listener *l) send_log(p, LOG_EMERG, "Proxy %s reached the configured maximum connection limit. Please check the global 'maxconn' value.\n", p->id); - conn_free(cli_conn); close(cli_conn->handle.fd); + conn_free(cli_conn); expire = tick_add(now_ms, 1000); /* try again in 1 second */ goto limit_global; } -- 1.7.10.4