From abf8e14bb270e9ff7100bd21c7953c6ac9ff9d98 Mon Sep 17 00:00:00 2001 From: Tim Duesterhus Date: Sun, 3 Jan 2021 01:29:55 +0100 Subject: [PATCH] CLEANUP: ssl: Remove useless loop in tlskeys_list_get_next() This loop was always exited in the first iteration by `return`. (cherry picked from commit 2c7bb33144d1cb89962f592062c9450870b662af) Signed-off-by: William Lallemand --- src/ssl_sock.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/ssl_sock.c b/src/ssl_sock.c index 4c91f8f..07b2123 100644 --- a/src/ssl_sock.c +++ b/src/ssl_sock.c @@ -6410,17 +6410,14 @@ struct tls_keys_ref *tlskeys_list_get_next(struct tls_keys_ref *getnext, struct { struct tls_keys_ref *ref = getnext; - while (1) { + /* Get next list entry. */ + ref = LIST_NEXT(&ref->list, struct tls_keys_ref *, list); - /* Get next list entry. */ - ref = LIST_NEXT(&ref->list, struct tls_keys_ref *, list); - - /* If the entry is the last of the list, return NULL. */ - if (&ref->list == end) - return NULL; + /* If the entry is the last of the list, return NULL. */ + if (&ref->list == end) + return NULL; - return ref; - } + return ref; } static inline -- 1.7.10.4