From d6b4b6da3f08ecb3df633aea5d5d9f072ad52135 Mon Sep 17 00:00:00 2001 From: Amaury Denoyelle Date: Wed, 21 Apr 2021 11:50:26 +0200 Subject: [PATCH] BUG/MINOR: server: fix potential null gcc error in delete server gcc still reports a potential null pointer dereference in delete server function event with a BUG_ON before it. Remove the misleading NULL check in the for loop which should never happen. This does not need to be backported. --- src/server.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/server.c b/src/server.c index a6c67a0..6728e11 100644 --- a/src/server.c +++ b/src/server.c @@ -4563,12 +4563,12 @@ static int cli_parse_delete_server(char **args, char *payload, struct appctx *ap } else { struct server *next; - for (next = be->srv; next && srv != next->next; next = next->next) - ; + for (next = be->srv; srv != next->next; next = next->next) { + /* srv cannot be not found since we have already found + * it with get_backend_server */ + BUG_ON(!next); + } - /* srv cannot be not found since we have already found it - * with get_backend_server */ - BUG_ON(!next); next->next = srv->next; } -- 1.7.10.4