BUG/MINOR: proxy: fix dump_server_state()'s misuse of the trash
authorWilly Tarreau <w@1wt.eu>
Wed, 1 Jul 2020 05:02:42 +0000 (07:02 +0200)
committerChristopher Faulet <cfaulet@haproxy.com>
Fri, 3 Jul 2020 17:03:55 +0000 (19:03 +0200)
commit00b4b530a2f505667e65c556aeacc6a9c1267700
tree94859e3610fa104dbbd88653834aff2843a3ca4a
parent37790a22a7d1ff27f016bedfd5dfabf48f0726b0
BUG/MINOR: proxy: fix dump_server_state()'s misuse of the trash

dump_server_state() claims to dump into a buffer but instead it writes
into a buffer then dumps the trash into the channel, so it only supports
being called with buf=&trash and doesn't need this buffer. There doesn't
seem to be any current impact of this mistake since the function is called
from one location only.

A backport may be performed if it helps fixing other bugs but it will not
fix an existing bug by itself.

(cherry picked from commit 6ff8143f7c87ad40d7369119467d779642702ad5)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
src/proxy.c