BUG/MEDIUM: ssl: fix the id length check within smp_fetch_ssl_fc_session_id()
authorDragan Dosen <ddosen@haproxy.com>
Mon, 4 May 2020 07:07:28 +0000 (09:07 +0200)
committerChristopher Faulet <cfaulet@haproxy.com>
Wed, 20 May 2020 16:43:59 +0000 (18:43 +0200)
commit1028e256e249bc75893b108154fc499ab1b5f825
tree214697de30ad8989e08293e25ab9df1366ffa3f5
parent226ca1a0ca39efff8277e015f7d2fd12278d8dc5
BUG/MEDIUM: ssl: fix the id length check within smp_fetch_ssl_fc_session_id()

After we call SSL_SESSION_get_id(), the length of the id in bytes is
stored in "len", which was never checked. This could cause unexpected
behavior when using the "ssl_fc_session_id" or "ssl_bc_session_id"
fetchers (eg. the result can be an empty value).

The issue was introduced with commit 105599c ("BUG/MEDIUM: ssl: fix
several bad pointer aliases in a few sample fetch functions").

This patch must be backported to 2.1, 2.0, and 1.9.

(cherry picked from commit f35d69e7fc13aab89afcf394c5b96133d3060c1a)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
src/ssl_sock.c