BUG/MINOR: mux-h2: prevent past scheduling with idle connections
authorAmaury Denoyelle <adenoyelle@haproxy.com>
Wed, 9 Apr 2025 12:26:54 +0000 (14:26 +0200)
committerWilly Tarreau <w@1wt.eu>
Thu, 17 Apr 2025 15:48:29 +0000 (17:48 +0200)
commit516121499c8edafb67a861bcd1bf41b3cc6f12d2
treedf903d4904759812d9f7efd44a8db3a22733815a
parentdb879777dc498da7eddb2acf893e72efa95032df
BUG/MINOR: mux-h2: prevent past scheduling with idle connections

While reviewing HTTP/2 MUX timeout, it seems there is a possibility that
MUX task is requeued via h2c_update_timeout() with an already expired
date. This can happens with idle connections on two cases :
* first with shut timeout, as timer is not refreshed if already set
* second with http-request and keep-alive timers, which are based on
  idle_start

Queuing an already expired task is an undefined behavior. Fix this by
using task_wakeup() instead of task_queue() at the end of
h2c_update_timeout() if such case occurs.

This should be backported up to 2.6.

(cherry picked from commit 3ebdd3ae509236af1f19d80cab98b385a751426b)
Signed-off-by: Willy Tarreau <w@1wt.eu>
src/mux_h2.c