BUG/MAJOR: mux-fcgi: Stop sending loop if FCGI stream is blocked for any reason
authorChristopher Faulet <cfaulet@haproxy.com>
Tue, 19 May 2020 13:13:00 +0000 (15:13 +0200)
committerChristopher Faulet <cfaulet@haproxy.com>
Wed, 20 May 2020 17:12:57 +0000 (19:12 +0200)
commit7622ee2949f882e7da08cecf6839cb78085e4ec8
tree0194a46dbe9ea0277916abb83972d02e7c0f2089
parent4508b775d41f294e3c149a43f2eec70f23bf1782
BUG/MAJOR: mux-fcgi: Stop sending loop if FCGI stream is blocked for any reason

Because of a typo error in conditions to exit the sending loop, it is possible
to loop infinitely in fcgi_snd_buf() function. Instead of checking the FCGI
stream is not blocked to continue sending data, the FCGI connection is used. So
it is possible to have a stream blocked because there is not enough space in the
mux buffers to copy more data but continue to loop to send more data.

This patch should fix the issue #637. It must be backported to 2.1.

(cherry picked from commit fe410d685ad8bce7399e50695098b69aea07e558)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
src/mux_fcgi.c