BUG/MINOR: proxy/session: Be sure to have a listener to increment its counters
authorChristopher Faulet <cfaulet@haproxy.com>
Fri, 12 Mar 2021 08:16:27 +0000 (09:16 +0100)
committerChristopher Faulet <cfaulet@haproxy.com>
Fri, 12 Mar 2021 12:47:13 +0000 (13:47 +0100)
commitbc48e77cd4716a15d57f04d533af73c58a94ab32
treec16fc3a8fb4cf1504edd81a3f090c9d1429edb60
parentbf6811332d4b514f6346a385f6acca9c094d1230
BUG/MINOR: proxy/session: Be sure to have a listener to increment its counters

It is possible to have a session without a listener. It happens for applets
on the client side. Thus all accesses to the listener info from the session
must be guarded. It was the purpose of the commit 36119de18 ("BUG/MEDIUM:
session: NULL dereference possible when accessing the listener"). However,
some tests on the session's listener existence are missing in proxy_inc_*
functions.

This patch should fix the issues #1171, #1172, #1173, #1174 and #1175. It
must be backported with the above commit as far as 1.8.

(cherry picked from commit 77e376783e891fe5dda4fe4e1198cf8dff0b118d)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit d57f8b2b30875e2f5c0c4452a1ec719b9c308041)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit d571a771c3bc35e4d1054b85389bf39a062b26ac)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
include/proto/proxy.h