projects / haproxy-2.1.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3cfc2f1) | patch
BUG/MINOR: protocol_buffer: Wrong maximum shifting.
authorFrédéric Lécaille <flecaille@haproxy.com>
Thu, 2 Apr 2020 12:24:31 +0000 (14:24 +0200)
committerWilly Tarreau <w@1wt.eu>
Thu, 2 Apr 2020 13:11:26 +0000 (15:11 +0200)
commitc7a203a6c75e4efff5f3d5d675d925f11b47dba1
tree9991019621b1e7f918043fefda05803343de35f9tree | snapshot
parent3cfc2f1d978f475c258dcd8c60b2bff8d02be92ccommit | diff
BUG/MINOR: protocol_buffer: Wrong maximum shifting.

This patch fixes a bad stop condition when decoding a protocol buffer variable integer
whose maximum lenghts are 10, shifting a uint64_t value by more than 63.

Thank you to Ilya for having reported this issue.

Must be backported to 2.1 and 2.0.

(cherry picked from commit 876ed55d9b8d0c298b6cac1003ec365a19bf7aad)
Signed-off-by: Willy Tarreau <w@1wt.eu>
include/proto/protocol_buffers.h diff | blob | history
haproxy-2.1 public tree. Stable production code.