MINOR: sink: Remove useless test on SE_FL_SHR/SHW flags
authorAurelien DARRAGON <adarragon@haproxy.com>
Tue, 23 Jul 2024 17:02:29 +0000 (19:02 +0200)
committerAurelien DARRAGON <adarragon@haproxy.com>
Tue, 14 Oct 2025 08:55:45 +0000 (10:55 +0200)
Re-apply dcd917d972 ("MINOR: applet: Remove uselelss test on SE_FL_SHR/SHW
flags") for sink_forward_oc_io_handler() function as it was probably
overlooked given that sink_forward_oc_io_handler() and
sink_forward_io_handler() follow the same logic.

(cherry picked from commit f2848e6146faa0794a9878610602d03608af07df)
[ada: required to fix applet not destroyed upon server disconnect,
 see GH #3153, the test turned out to be mandatory, not useless]
Signed-off-by: Aurelien DARRAGON <adarragon@haproxy.com>

src/sink.c

index be942ad..ba2bdb9 100644 (file)
@@ -426,7 +426,7 @@ static void sink_forward_oc_io_handler(struct appctx *appctx)
        size_t ofs, last_ofs;
        int ret = 0;
 
-       if (unlikely(se_fl_test(appctx->sedesc, (SE_FL_EOS|SE_FL_ERROR|SE_FL_SHR|SE_FL_SHW))))
+       if (unlikely(se_fl_test(appctx->sedesc, (SE_FL_EOS|SE_FL_ERROR))))
                goto out;
 
        /* if stopping was requested, close immediately */