BUG/MINOR: quic: Missing SSL session object freeing

qc_alloc_ssl_sock_ctx() allocates an SSL_CTX object for each connection. It also
allocates an SSL object. When this function failed, it freed only the SSL_CTX object.
The correct way to free both of them is to call qc_free_ssl_sock_ctx().

Must be backported as far as 2.6.

(cherry picked from commit 6b746330692380f7e88fc757b7124b5a9c88ebd8)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit aaef9e0000fb2fc6011d9a95e6e7f5241863db8f)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>

diff --git a/src/quic_ssl.c b/src/quic_ssl.c
index 4734136..2bef9ac 100644 (file)
--- a/src/quic_ssl.c
+++ b/src/quic_ssl.c
@@ -874,6 +874,6 @@ int qc_alloc_ssl_sock_ctx(struct quic_conn *qc)
 
  err:
        TRACE_DEVEL("leaving on error", QUIC_EV_CONN_NEW, qc);
-       pool_free(pool_head_quic_ssl_sock_ctx, ctx);
+       qc_free_ssl_sock_ctx(&ctx);
        goto leave;
 }