projects
/
haproxy-2.3.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c4615c6
)
MINOR: mux-h1/show_fd: report as suspicious an entry with too many calls
author
Willy Tarreau
<w@1wt.eu>
Thu, 21 Jan 2021 08:13:35 +0000
(09:13 +0100)
committer
Willy Tarreau
<w@1wt.eu>
Thu, 28 Jan 2021 17:13:36 +0000
(18:13 +0100)
An FD entry that maps to an H1 connection whose stream was woken
up more than 1M times is now flagged as suspicious.
(cherry picked from commit
0c0c0a287834283eaaf5f25437a39a8f059e9878
)
Signed-off-by: Willy Tarreau <w@1wt.eu>
src/mux_h1.c
patch
|
blob
|
history
diff --git
a/src/mux_h1.c
b/src/mux_h1.c
index
7b07bb7
..
94006e6
100644
(file)
--- a/
src/mux_h1.c
+++ b/
src/mux_h1.c
@@
-2900,6
+2900,7
@@
static int h1_show_fd(struct buffer *msg, struct connection *conn)
{
struct h1c *h1c = conn->ctx;
struct h1s *h1s = h1c->h1s;
+ int ret = 0;
chunk_appendf(msg, " h1c.flg=0x%x .sub=%d .ibuf=%u@%p+%u/%u .obuf=%u@%p+%u/%u",
h1c->flags, h1c->wait_event.events,
@@
-2931,12
+2932,14
@@
static int h1_show_fd(struct buffer *msg, struct connection *conn)
chunk_appendf(&trash, " tl.calls=%d tl.ctx=%p tl.fct=",
h1s->subs->tasklet->calls,
h1s->subs->tasklet->context);
+ if (h1s->subs->tasklet->calls >= 1000000)
+ ret = 1;
resolve_sym_name(&trash, NULL, h1s->subs->tasklet->process);
chunk_appendf(&trash, ")");
}
}
}
- return 0;
+ return ret;
}