MINOR: mux-spop: Don't set SPOP connection state to FRAME_H after ACK parsing
authorChristopher Faulet <cfaulet@haproxy.com>
Tue, 13 May 2025 16:41:09 +0000 (18:41 +0200)
committerWilly Tarreau <w@1wt.eu>
Thu, 15 May 2025 15:01:44 +0000 (17:01 +0200)
After the ACK frame was parsed, it is useless to set the SPOP connection
state to SPOP_CS_FRAME_H state because this will be automatically handled by
the demux function. If it is not an issue, but this will simplify changes
for the next commit.

(cherry picked from commit 6b0f7de4e34c7da1ec7ae82e8e8a298823e50d72)
Signed-off-by: Willy Tarreau <w@1wt.eu>

src/mux_spop.c

index c3d0214..c0682f6 100644 (file)
@@ -1936,7 +1936,6 @@ static int spop_conn_handle_ack(struct spop_conn *spop_conn, struct spop_strm *s
 
        spop_strm->flags |= SPOP_SF_ACK_RCVD;
        TRACE_PROTO("SPOP AGENT ACK frame rcvd", SPOP_EV_RX_FRAME|SPOP_EV_RX_ACK, spop_conn->conn, spop_strm, 0, (size_t[]){sent});
-       spop_conn->state = SPOP_CS_FRAME_H;
        TRACE_LEAVE(SPOP_EV_RX_FRAME|SPOP_EV_RX_ACK, spop_conn->conn, spop_strm);
        return 1;