BUG/MINOR: peers: Possible appctx pointer dereference.
authorFrédéric Lécaille <flecaille@haproxy.com>
Sun, 17 Jan 2021 12:08:39 +0000 (13:08 +0100)
committerChristopher Faulet <cfaulet@haproxy.com>
Tue, 26 Jan 2021 09:09:05 +0000 (10:09 +0100)
This bug may occur when enabling peers traces. It is possible that
peer->appctx is NULL when entering peer_session_release().

(cherry picked from commit 4b1a05fcf81b4343d29aeb86394d44f29d2116a4)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>

src/peers.c

index a530a33..a38fc3c 100644 (file)
@@ -425,7 +425,7 @@ static void peers_trace(enum trace_level level, uint64_t mask,
                        const struct peer *peer = a2;
                        struct peers *peers = NULL;
 
-                       if (peer) {
+                       if (peer && peer->appctx) {
                                struct stream_interface *si;
 
                                si = peer->appctx->owner;