BUG/MINOR: mux-h2: Fix typo in scheme adjustment
authorTim Duesterhus <tim@bastelstu.be>
Sun, 28 Feb 2021 15:12:20 +0000 (16:12 +0100)
committerChristopher Faulet <cfaulet@haproxy.com>
Wed, 3 Mar 2021 15:34:50 +0000 (16:34 +0100)
That comma should've been a semicolon. Fortunately, as it is now there
is no impact thanks to operators precedence, and all expressions are
properly evaluated. But this is troubling and the risk is high to
turn it into an effective bug with a minor change.

Introduced in b8ce8905cf63ecd06b36af39c05103fadf3cc347 which first
appeared in 2.1-dev3. This fix must be backported to 2.1+.

(cherry picked from commit a3298023b04923ba12429d79c559dc7a850ae122)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 31871d22827508fcbfe1064a831d220084e19d74)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 21e7aa3f57be44c2b41b4b40056e74374b229438)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>

src/mux_h2.c

index 23f3671..36b32e3 100644 (file)
@@ -4995,7 +4995,7 @@ static size_t h2s_bck_make_req_headers(struct h2s *h2s, struct htx *htx)
                        if (len + 2 < uri.len && uri.ptr[len + 1] == '/' && uri.ptr[len + 2] == '/') {
                                /* make the uri start at the authority now */
                                scheme.ptr = uri.ptr;
-                               scheme.len = len,
+                               scheme.len = len;
                                uri.ptr += len + 3;
                                uri.len -= len + 3;