BUG/MINOR: quic: wrong bbr_target_inflight() implementation
authorFrederic Lecaille <flecaille@haproxy.com>
Thu, 12 Dec 2024 10:44:10 +0000 (11:44 +0100)
committerChristopher Faulet <cfaulet@haproxy.com>
Mon, 6 Jan 2025 10:17:54 +0000 (11:17 +0100)
This bug arrived with this commit:

  6404b7a18a BUG/MINOR: quic: fix bbr_inflight() calls with wrong gain value

This patch partially reverts after having checked the BBR v3 draft.
This bug was invisible when testing long BBR flows.

Must be backported to 3.1.

(cherry picked from commit 2bcd5b4cba4e9f123860560de0807312b909b306)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>

src/quic_cc_bbr.c

index a164c1f..b08c4b5 100644 (file)
@@ -840,7 +840,7 @@ static void bbr_exit_probe_rtt(struct bbr *bbr)
 
 static uint64_t bbr_target_inflight(struct bbr *bbr, struct quic_cc_path *p)
 {
-       uint64_t bdp = bbr_inflight(bbr, p, bbr->bw, bbr->cwnd_gain);
+       uint64_t bdp = bbr_inflight(bbr, p, bbr->bw, 100);
        return MIN(bdp, p->cwnd);
 }