BUG/MINOR: ssl: Missing calloc return value check in ssl_init_single_engine

A memory allocation failure happening during ssl_init_single_engine
would have resulted in a crash. This function is only called during
init.

It was raised in GitHub issue #1233.
It could be backported to all stable branches.

(cherry picked from commit 612b2c37be70636e73698c6c064af9522301be65)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 46697c80fec88e656a4f7280a2cfa9dedbfb33a5)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>

diff --git a/src/ssl_sock.c b/src/ssl_sock.c
index 630aa57..1561ddc 100644 (file)
--- a/src/ssl_sock.c
+++ b/src/ssl_sock.c
@@ -645,6 +645,8 @@ int ssl_init_single_engine(const char *engine_id, const char *def_algorithms)
        }
 
        el = calloc(1, sizeof(*el));
+       if (!el)
+               goto fail_alloc;
        el->e = engine;
        LIST_ADD(&openssl_engines, &el->list);
        nb_engines++;
@@ -652,6 +654,7 @@ int ssl_init_single_engine(const char *engine_id, const char *def_algorithms)
                global.ssl_used_async_engines = nb_engines;
        return 0;
 
+fail_alloc:
 fail_set_method:
        /* release the functional reference from ENGINE_init() */
        ENGINE_finish(engine);