BUG/MEDIUM: threads: Disable the workaround to load libgcc_s on macOS

Don't use the workaround to load libgcc_s on macOS. It is not needed
there, and it causes issues, as recent macOS dislike processes that fork
after threads where created (and the workaround creates a temporary
thread). This fixes crashes on macOS at least when using master-worker,
and using the system resolver.

This should fix Github issue #3035

This should be backported up to 2.8.

(cherry picked from commit f8e9545f700a4e3799bbac4cd1c94989b9c1fb61)
Signed-off-by: Amaury Denoyelle <adenoyelle@haproxy.com>
(cherry picked from commit 0d87b8343f8780c1c677dd282dc7648cf038a00a)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit ba9ee8147702b5cc5c400b7521afc2f13659eb2c)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>

diff --git a/src/thread.c b/src/thread.c
index 8d65e83..87ed0e7 100644 (file)
--- a/src/thread.c
+++ b/src/thread.c
@@ -1068,6 +1068,7 @@ int pthread_rwlock_unlock(pthread_rwlock_t *rwlock)
 }
 #endif // defined(USE_PTHREAD_EMULATION)
 
+#ifndef __APPLE__
 /* Depending on the platform and how libpthread was built, pthread_exit() may
  * involve some code in libgcc_s that would be loaded on exit for the first
  * time, causing aborts if the process is chrooted. It's harmless bit very
@@ -1088,12 +1089,15 @@ static inline void preload_libgcc_s(void)
        if (pthread_create(&dummy_thread, NULL, dummy_thread_function, NULL) == 0)
                pthread_join(dummy_thread, NULL);
 }
+#endif
 
 static void __thread_init(void)
 {
        char *ptr = NULL;
 
+#ifndef __APPLE__
        preload_libgcc_s();
+#endif
 
        thread_cpus_enabled_at_boot = thread_cpus_enabled();
        thread_cpus_enabled_at_boot = MIN(thread_cpus_enabled_at_boot, MAX_THREADS);