From: Willy Tarreau <w@1wt.eu>
Date: Wed, 17 Jan 2024 15:56:18 +0000 (+0100)
Subject: MINOR: mux-h2/traces: add a missing trace on connection WU with negative inc
X-Git-Tag: v2.9.4~21
X-Git-Url: http://git.haproxy.org/?a=commitdiff_plain;h=3342e1ea950b43cfeafccb4a516024443eb48252;p=haproxy-2.9.git

MINOR: mux-h2/traces: add a missing trace on connection WU with negative inc

The test was performed but no trace emitted, which can complicate certain
diagnostics, so let's just add the trace for this rare case. It may safely
be backported though this is really not important.

(cherry picked from commit 87b74697cd58f7780f3585f70a1966553192830f)
Signed-off-by: Willy Tarreau <w@1wt.eu>
---

diff --git a/src/mux_h2.c b/src/mux_h2.c
index 826445e..b1500cb 100644
--- a/src/mux_h2.c
+++ b/src/mux_h2.c
@@ -2603,6 +2603,7 @@ static int h2c_handle_window_update(struct h2c *h2c, struct h2s *h2s)
 		}
 
 		if (h2c->mws >= 0 && h2c->mws + inc < 0) {
+			TRACE_ERROR("conn WINDOW_UPDATE inc<0", H2_EV_RX_FRAME|H2_EV_RX_WU, h2c->conn);
 			error = H2_ERR_FLOW_CONTROL_ERROR;
 			goto conn_err;
 		}